complete interactions/buttons.mdx page#60
Conversation
- Add basic View example - Add example for handling timeout (disabling buttons and clear_items) - Move low level example to Views vs low-level section
shiftinv
added
t: page/section addition
shiftinv
left a comment
shiftinv
left a comment
There was a problem hiding this comment.
ty! This looks good, most of my comments are about formatting and other minor nits.
A more general comment about the entire guide's structure:
With the addition of this page, the guide starts having some redundancy between the pages for buttons and select menus, both regarding view timeouts and low-level components.
This isn't relevant to this PR directly, but we should refactor common sections into a separate page in the future.
I was thinking the same thing as I was working on this. |
remove unnecessary "default timeout" comment Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
correct View Example link Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
remove unneeded comment in disabled button example Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
adjust comment structure in button_view example Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
remove ellipses from example Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
remove unnecessary comment in timeout example Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
wording in timeout example slash command Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
remove unneeded custom_id check in low level example Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
reword comments in timeout example remove duplicate comments from second button callback.
2 participants
Description
Complete the interactions/buttons page
Relevant Issues
Closes #59