Added options to return or include raw data from query#112
Open
nmisyats wants to merge 7 commits intoDinoTools:masterfrom
Open
Added options to return or include raw data from query#112nmisyats wants to merge 7 commits intoDinoTools:masterfrom
nmisyats wants to merge 7 commits intoDinoTools:masterfrom
Conversation
The `include_raw` parameter in the `query`, `parse_json` and `parse_xml` methods allow to keep a copy of the raw data (str or bytes) returned by the query in a `raw` field in the parsed result.
If `raw` is set to True when calling `query`, the raw str or bytes of the response are returned.
Removed `raw` argument from the `query` method, which only returns the parsed result (as originally). The `query_raw` is used to return the raw bytes or string, along with the response's content type. This should fix the typing errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue type
Summary
Added options to keep the raw XML or JSON response along with the parsed result, and a method to return only
the raw response.
The latter fixes #79.
Example: