simplify urlopen reading code. make the runtime linear rather than quadratic#111
Open
kavigupta wants to merge 1 commit intoDinoTools:masterfrom
Open
simplify urlopen reading code. make the runtime linear rather than quadratic#111kavigupta wants to merge 1 commit intoDinoTools:masterfrom
kavigupta wants to merge 1 commit intoDinoTools:masterfrom
Conversation
Frankkkkk
added a commit
to Frankkkkk/python-overpy
that referenced
this pull request
May 6, 2024
There is no need to support chunks in python3 as the `read()` interface does that for us. Furthermore, this improves fetch performance in large queries (c.f. DinoTools#111). Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
Frankkkkk
added a commit
to Frankkkkk/python-overpy
that referenced
this pull request
May 7, 2024
There is no need to support chunks in python3 as the `read()` interface does that for us. Furthermore, this improves fetch performance in large queries (c.f. DinoTools#111). Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue type
The code hangs when accessing a large query (e.g., all parks in California). This is because the code as written repeatedly adds to a string in a loop. This is (1) not necessary, since you can just run f.read() and (2) unnecessarily slow, as it requires reallocation and copying of the entire string. See, e.g., this amazon style guide for more details.
Summary
I replaced a block of code
with the line
This is equivalent