[WIP] Track redrew with some color code#696
Open
howard0su wants to merge 1 commit intoDeviationTX:masterfrom
Open
[WIP] Track redrew with some color code#696howard0su wants to merge 1 commit intoDeviationTX:masterfrom
howard0su wants to merge 1 commit intoDeviationTX:masterfrom
Conversation
| if (changed) { | ||
| changed = false; | ||
| #ifdef BUILDTYPE_DEV | ||
| for (int x = 0; x < LCD_WIDTH; x++) |
Contributor
There was a problem hiding this comment.
This probably needs to be configurable rather than always on with dev builds
Contributor
Author
|
yes. I want to have another option on the EMU right panel like the inputs
today. didn't get time to do that yet.
…On Sun, Feb 17, 2019 at 10:30 PM PhracturedBlue ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/target/common/emu/fltk.cpp
<#696 (comment)>:
> @@ -665,8 +665,42 @@ void PWR_Sleep() {
void LCD_ForceUpdate() {
if (changed) {
changed = false;
+#ifdef BUILDTYPE_DEV
+ for (int x = 0; x < LCD_WIDTH; x++)
This probably needs to be configurable rather than always on with dev
builds
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#696 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAuzRKnoYxVszfUM2v7OZ9CsIyDgq9tmks5vOWeOgaJpZM4a_jqh>
.
--
-Howard
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is similar to Android debug option to track redraw times. It colors UI elements to identify the amount of overdraw as follows: