Use Vortex Motor Parameters When Applicable in SwerveModule#122
Use Vortex Motor Parameters When Applicable in SwerveModule#122
Conversation
There was a problem hiding this comment.
LGTM minus the one thing below. As a heads up, the value changes will drop the current limit by ~10A (by my math). Not detrimental, but wanted to make sure you had that in mind.
Interesting note w/ the NEO 2.0 comment. Maybe consider adding a DCMotor to SwerveConfig and pulling the values from there? No need to do that in this PR tho. (Unless you want to.)
src/main/java/org/carlmontrobotics/lib199/swerve/SwerveModule.java
Outdated
Show resolved
Hide resolved
timtogan
left a comment
There was a problem hiding this comment.
Only thing on top of Ryan's I would change is we should probably cap the current limit at 40 amps instead of 50 as we use 40 amp fuses. Concerning neo 2.0 we don't have any plans on switching to them so I think it's fine to leave it like that.
Co-authored-by: CoolSpy3 <55305038+CoolSpy3@users.noreply.github.com>
This I did not take in account. Would it be like 30A? Cause when I did my calculations I got 57A which would get limited by the |
Actually, that's my bad. I also worked it out to 50-something amps. I just mentally did a |
Apply the correct smartCurrent limit based of the right motor: NEO or NEO Vortex