Un-break nix build + nix develop#135
Merged
mchav merged 2 commits intoDataHaskell:mainfrom Jan 22, 2026
Merged
Conversation
random must be on 1.3.1 for dataframe, which is incompatible with time-compat's tests, so skip time-compat's tests
Using the package means that e.g. `cabal repl` works with all of the dependencies / package-defined code, so you can ``` $ cabal repl [...] Ok, 46 modules loaded. ghci> import DataFrame.IO.CSV ghci> readCsv "foo.csv" --------- a | b ----|---- Int | Int ----|---- 1 | 2 3 | 4 5 | 6 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
main,nix buildfails with missingrandom >=1.3 && <2. That makes sense, since the version ofrandominhaskellPackagesin the flake inputs was 1.2.x. This PR overridesrandominhsPkgsto pin to1.3.1instead. A consequence of that was thattime-compattests broke, because they depend on random between 1.2 and 1.3, so it also overridestime-compatto skip tests.This PR also updates the dev shell to provide a little more power. On
main, if younix develop, you get vanillacabalwithout any knowledge of the project's dependencies, e.g.After changes in this PR, the dev shell is aware of the
dataframepackage, andcabal repldrops you into a shell with all of the project's modules, so if you havefoo.csvlikeyou can