fix writeCsv for OptionalColumn #134
Merged
mchav merged 2 commits intoDataHaskell:mainfrom Jan 21, 2026
Merged
Conversation
Member
|
Great catch and fix. I'll include some round trip tests in a follow up. |
Member
|
@mcoady text show doesn't seem to work for older ghcs. Can we in the mean time add another case statement matching |
Contributor
Author
|
Ah, my bad - I see As an aside - excellent project btw! I'm looking to replace some python/polars with this so happy to provide feedback if I stumble across anything else, but liking it so far! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
writeCsvwas outputting optional (non-Text) values as text including Just/Nothing in the file. You can see this behaviour doing a read/write/read cycle (see below). On Windows btw.Example
Input
Behaviour before
Behaviour after