Fix crypto IV handling, SQLite method calls, and exception namespacing

[Copilot]

Addresses code review feedback on cryptography implementation, SQLite method resolution, and exception handling in namespaced context.

Crypto.php

• Add OPENSSL_RAW_DATA flag to encryption/decryption operations. Previous implementation concatenated base64-encoded ciphertext with raw IV bytes, producing invalid data. Now encrypts to raw bytes, concatenates with raw IV, then base64-encodes the combined output.

// Before: base64 ciphertext + raw IV bytes (invalid)
$encrypted = openssl_encrypt($str, $method, $password, iv: $ivRaw);
return base64_encode($ivRaw . $encrypted);

// After: raw IV + raw ciphertext, then base64 (valid)
$encrypted = openssl_encrypt($str, $method, $password, OPENSSL_RAW_DATA, $ivRaw);
return base64_encode($ivRaw . $encrypted);

SQLite.php

• Remove unreachable code after early return in sqlite_function() (lines 428-439)
• Fix unqualified method calls: sqlite_table_exists() → $this->sqlite_table_exists()
• Qualify exception type: catch (Exception $e) → catch (\Exception $e) for namespace correctness with strict_types=1

Times.php

• Rename $now/$then to $currentTime/$inputTime for semantic clarity

CI

• Add imagick extension to workflow for Images class test coverage

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/nikic/PHP-Parser/zipball/dca41cd15c2ac9d055ad70dbfd011130757d1f82
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/cli-parser/zipball/15c5dd40dc4f38794d383bb95465193f5e0ae180
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/code-unit-reverse-lookup/zipball/183a9b2632194febd219bb9246eee421dad8d45e
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/code-unit/zipball/54391c61e4af8078e5b276ab082b6d3c54c9ad64
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/comparator/zipball/2c95e1e86cb8dd41beb8d502057d1081ccc8eca9
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/complexity/zipball/ee41d384ab1906c68852636b6de493846e13e5a0
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/diff/zipball/b4ccd857127db5d41a5b676f24b51371d76d8544
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/environment/zipball/a5c75038693ad2e8d4b6c15ba2403532647830c4
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/exporter/zipball/70a298763b40b213ec087c51c739efcaa90bcd74
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/global-state/zipball/3be331570a721f9a4b5917f4209773de17f747d7
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/lines-of-code/zipball/d36ad0d782e5756913e42ad87cb2890f4ffe467a
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/f5b498e631a74204185071eb41f33f38d64608aa
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/6e1a43b411b2ad34146dee7524cb13a068bb35f9
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/2c1ed04922802c15e1de5d7447b4856de949cf56
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/php-file-iterator/zipball/2f3a64888c814fc235386b7387dd5b5ed92ad903
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/php-invoker/zipball/c1ca3814734c07492b3d4c5f794f4b0995333da2
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/php-text-template/zipball/3e0404dc6b300e6bf56415467ebcb3fe4f33e964
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/php-timer/zipball/3b415def83fbcb41f991d9ebf16ae4ad8b7837b3
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/phpunit/zipball/fdfc727f0fcacfeb8fcb30c7e5da173125b58be3
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/f6458abbf32a6c8174f8f26261475dc133b3d9dc
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/type/zipball/f77d2d4e78738c98d9a68d2596fe5e8fa380f449
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/version/zipball/c687e3387b99f5b03b6caa64c74b63e2936ff874
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/staabm/side-effects-detector/zipball/d8334211a140ce329c13726d4a715adbddd0a163
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AJZ1TK /usr/bin/composer install --prefer-dist --no-progress (http block)
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
• https://api.github.com/repos/theseer/tokenizer/zipball/b7489ce515e168639d17feec34b8847c326b0b3c
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/k6olXw /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This pull request addresses code review feedback by fixing critical bugs in cryptography implementation, correcting method resolution in SQLite operations, and ensuring proper exception handling in namespaced context with strict types.

Changes:

• Fixed crypto IV handling by adding OPENSSL_RAW_DATA flag to prevent mixing base64-encoded ciphertext with raw IV bytes
• Corrected unqualified method calls in SQLite.php by adding $this-> prefix
• Fixed exception handling to use fully qualified \Exception class for namespace correctness with strict_types=1
• Improved code clarity by renaming variables and removing unreachable code
• Added imagick extension to CI workflow for future test coverage

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
PHPUtils/Crypto.php	Adds OPENSSL_RAW_DATA flag to encryption/decryption to properly handle raw bytes instead of base64, fixing data corruption bug
PHPUtils/SQLite.php	Fixes unqualified method calls with $this-> prefix, qualifies Exception class with backslash for strict types, removes unreachable code after return statement
PHPUtils/Times.php	Renames variables from $now/$then to $currentTime/$inputTime for better semantic clarity
.github/workflows/php.yml	Adds imagick extension to CI workflow to support Images class functionality

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The fallback logic base64_decode($str, true) ?: $str creates API ambiguity when an external IV is provided. The function accepts both base64-encoded and raw ciphertext, but this dual behavior is not documented in the docstring. Consider either: (1) requiring a specific format and documenting it clearly, or (2) adding a parameter to explicitly specify the input format. The current implementation may lead to silent errors if a user mistakenly passes the wrong format.