Correct chord forming#8
Open
BooLTonian wants to merge 1 commit intoCup0fCode:masterfrom
BooLTonian:patch-1
Open
Correct chord forming#8BooLTonian wants to merge 1 commit intoCup0fCode:masterfrom BooLTonian:patch-1
BooLTonian wants to merge 1 commit intoCup0fCode:masterfrom
BooLTonian:patch-1
Conversation
Your major system was creating augmented chords, and your minor system was creating major chords. As such, I corrected the step count. This should also be paired with a fork I'm putting on Instruments/listeners/InventoryClick.java which will make it so the bool minor actually activates the minor functionality instead of the major functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your major system was creating augmented chords, and your minor system was creating major chords. As such, I corrected the step count. This should also be paired with a fork I'm putting on Instruments/listeners/InventoryClick.java which will make it so the bool minor actually activates the minor functionality instead of the major functionality.