Open
Conversation
slimline33
commented
Nov 23, 2024
- BalloonTip Management: The BalloonTip is displayed only once when the window is minimized.
- Error Handling for Icon: If the icon file is not found, an error message is shown.
- Cleaned-Up Layout Logic: Visibility and update logic for layouts have been extracted into separate methods.
- SerialPort Communication: Error handling for serial commands has been added.
- Minimization to System Tray: When minimized, the program hides itself and moves to the system tray (right side of the taskbar).
- BalloonTip Management: The BalloonTip is displayed only once when the window is minimized. - Error Handling for Icon: If the icon file is not found, an error message is shown. - Cleaned-Up Layout Logic: Visibility and update logic for layouts have been extracted into separate methods. - SerialPort Communication: Error handling for serial commands has been added. - Minimization to System Tray: When minimized, the program hides itself and moves to the system tray (right side of the taskbar).
code optimierung
update to net6.0, ignore warnings, only windows
error in duplicate dll
Owner
|
Hi @slimline33, first of all, thank you so much for these improvements! I think that they are a great update to the project. And the Arduino sketch is much more compact and readable now! I'm very sorry that it took so long to review your pull request. I had to set up the Arduino and VS environments to get it to run. About the Companion App:
And for the Arduino sketch:
Und könntest du vielleicht deine Kommentare auf Englisch übersetzen? Zum Beispiel mit DeepL ginge das fix. Falls mal jemand außerhalb von Deutschland an dem Projekt weiterarbeiten will, wäre das vorteilhaft ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.