Allow float type in schema validation#23
Merged
CoolCat467 merged 4 commits intoCoolCat467:mainfrom Feb 9, 2026
Merged
Conversation
CoolCat467
requested changes
Feb 8, 2026
Owner
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
If you could change the unit tests to make sure we don't have a regression in the future that would be great, otherwise looks good.
i.e. add new unit test(s) that test added float functionality.
CoolCat467
changed the title
for more information, see https://pre-commit.ci
Contributor
Author
I added a test for large schemas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
having for example a schema with a minimum property and it being a float causes an error, this (hopefully) fixes that.