The java conversion of concore.py#4
Open
SudoSu-bham wants to merge 2 commits intoControlCore-Project:mainfrom
Open
The java conversion of concore.py#4SudoSu-bham wants to merge 2 commits intoControlCore-Project:mainfrom
SudoSu-bham wants to merge 2 commits intoControlCore-Project:mainfrom
Conversation
Member
|
Thanks, @SudoSu-bham. We will not merge this pull request as currently we do not have a Java version of concore and that is part of the proposed GSoC idea. But we will review this pull request and leave remarks when we have. Make sure to include a link to this pull request when you make your proposal. |
Author
|
Thankyou, I will keep that in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At line 198 in function
default_maxtime. I was unable to find the exact format/type of value stored inconcore.maxtimeI have assumed it to be an integer. Please let me know if any corrections are needed. Thankyou