Migrate to latest (Dev) Local and Client Cloud versions#1
Open
marksto wants to merge 12 commits intoComputeSoftware:masterfrom
Open
Migrate to latest (Dev) Local and Client Cloud versions#1marksto wants to merge 12 commits intoComputeSoftware:masterfrom
marksto wants to merge 12 commits intoComputeSoftware:masterfrom
Conversation
The following things have changed: - Dev Local name — from `dev-local` to just `local` - `local` is released under Apache 2.0, thus available through Maven - `:server-type` value — from `:dev-local` to `:datomic-local` https://docs.datomic.com/cloud/datomic-local.html?search=1.0.126#267
Reflection warning, dev_local_tu/core.clj:34:23 - reference to field getAbsolutePath can't be resolved.
Author
|
@kennyjwilli, hi! Can this PR be merged, can't it? |
Author
|
@kennyjwilli, hi! It would be nice if you can check and hopefully merge these changes. |
|
@marksto Have you considered publishing your branch under a different name? |
Author
|
@danmidwood Yeah, it's done now, but under a different artifact ID as well, with all the breaking changes to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kenny,
Thank you for a cute testing lib! It's been a while since your last last commit to the repo though, and things have changed in a way that makes it impossible the further use of this testing lib with the (currently) latest version of Datomic Cloud.
The following things have changed:
dev-localto justlocallocalis released under Apache 2.0, thus available through Maven:server-typevalue — from:dev-localto:datomic-localHere's a small patch that implements the necessary changes in
dev-local-tu. I've also upgraded Clojure version to1.11.1, which is currently the latest stable one. I also tweaked an obviously verbose piece of code and fixed a compiler reflection warning (pardon for shipping this along).Feel free to review and release an updated version of the artifact at your convenience.
Cheers,
Mark