Typographic quotation marks & shell-sessions#37
Open
toastal wants to merge 1 commit intoComponentDriven:nextfrom
Open
Typographic quotation marks & shell-sessions#37toastal wants to merge 1 commit intoComponentDriven:nextfrom
toastal wants to merge 1 commit intoComponentDriven:nextfrom
Conversation
* Move to typographically-correct apostrophes and quotation marks * The `sh` blocks were not for shell scripts, instead they are `shell-sessions`, things to run in your terminal emulator * PR to pull request as it is easier to understand --- Suggestion: change to AsciiDoc to get features you are emulating * images can have dimensions (replaces the first line needing HTML) * Definition lists are used (key-value lists), but instead Markdown bold is used * No need to use headings for titles for code block; some of these aren't document sections but just a description of the code block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shblocks were not for shell scripts, instead they areshell-sessions, things to run in your terminal emulatorSuggestion: change to AsciiDoc/reStructuredText to get features you are emulating
If the suggestion is liked, I would gladly convert the document instead of this merge request.