Closed
Conversation
Author
|
i cannot guarantee high quality code but i know that this works, i can also maintain it and do bugfixes |
robotgryphon
requested changes
Sep 24, 2025
neoforge-main/src/main/java/dev/compactmods/crafting/client/render/GhostRenderer.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/dev/compactmods/crafting/compat/jei/JeiMiniaturizationCraftingCategory.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/dev/compactmods/crafting/compat/jei/JeiMiniaturizationCraftingCategory.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/dev/compactmods/crafting/compat/jei/JeiMiniaturizationCraftingCategory.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/dev/compactmods/crafting/compat/jei/JeiMiniaturizationCraftingCategory.java
Outdated
Show resolved
Hide resolved
.../main/java/dev/compactmods/crafting/compat/theoneprobe/providers/FieldProjectorProvider.java
Outdated
Show resolved
Hide resolved
.../main/java/dev/compactmods/crafting/compat/theoneprobe/providers/FieldProjectorProvider.java
Outdated
Show resolved
Hide resolved
neoforge-main/src/main/java/dev/compactmods/crafting/recipes/MiniaturizationRecipe.java
Outdated
Show resolved
Hide resolved
neoforge-main/src/main/java/dev/compactmods/crafting/recipes/MiniaturizationRecipe.java
Outdated
Show resolved
Hide resolved
neoforge-main/src/main/resources/data/compactcrafting/recipe/oak_door.json
Outdated
Show resolved
Hide resolved
robotgryphon
requested changes
Oct 6, 2025
|
|
||
| ItemPredicate.CODEC.fieldOf("catalyst") | ||
| .forGetter(MiniaturizationRecipe::catalystTest) | ||
| ItemStack.STRICT_CODEC.fieldOf("catalyst") |
Collaborator
There was a problem hiding this comment.
Please revert this to ItemPredicate.CODEC - it still exists in 21.1 and does not cause breaks
Comment on lines
+182
to
+184
| ItemPredicate catalystPredicate = ItemPredicate.Builder.item() | ||
| .of(catalyst.getItem()) | ||
| .build(); |
Collaborator
There was a problem hiding this comment.
Revert to ItemPredicate, the old system worked fine
| } | ||
|
|
||
| @SubscribeEvent | ||
| public static void onRightClickBlock(final PlayerInteractEvent.RightClickBlock event) { |
Collaborator
There was a problem hiding this comment.
Why are you using an event for this instead of the block methods? The proxies share a base class.
Comment on lines
+21
to
+42
| public record FieldCenter(BlockPos center) { | ||
| } | ||
|
|
||
| public static final Codec<FieldCenter> FIELD_CENTER_CODEC = RecordCodecBuilder.create(instance -> | ||
| instance.group( | ||
| BlockPos.CODEC.fieldOf("center").forGetter(FieldCenter::center) | ||
| ).apply(instance, FieldCenter::new) | ||
| ); | ||
|
|
||
| public static final StreamCodec<RegistryFriendlyByteBuf, FieldCenter> FIELD_CENTER_STREAM_CODEC = | ||
| StreamCodec.composite( | ||
| BlockPos.STREAM_CODEC, FieldCenter::center, | ||
| FieldCenter::new | ||
| ); | ||
|
|
||
| public static final DeferredHolder<DataComponentType<?>, DataComponentType<FieldCenter>> FIELD_CENTER = | ||
| DATA_COMPONENTS.registerComponentType( | ||
| "field_center", | ||
| builder -> builder | ||
| .persistent(FIELD_CENTER_CODEC) | ||
| .networkSynchronized(FIELD_CENTER_STREAM_CODEC) | ||
| ); |
Collaborator
There was a problem hiding this comment.
Why add a specialized record for one thing that already has a codec? Just use a block position.
| public abstract class BaseFieldProxyEntity extends BlockEntity { | ||
|
|
||
| @Nullable | ||
| public BlockPos fieldCenter; |
Collaborator
There was a problem hiding this comment.
Should be protected not public
| @Nullable | ||
| protected IMiniaturizationField<MiniaturizationRecipe> field = null; | ||
|
|
||
| private UUID proxyId = UUID.randomUUID(); |
Comment on lines
+117
to
+119
| public UUID getProxyId() { | ||
| return proxyId; | ||
| } |
| MiniaturizationRecipeComponents.STREAM_CODEC, MiniaturizationRecipe::components, | ||
| ItemStack.LIST_STREAM_CODEC, MiniaturizationRecipe::codecOutputs, | ||
| ByteBufCodecs.fromCodecWithRegistries(ItemPredicate.CODEC), MiniaturizationRecipe::catalystMatcher, | ||
| ItemStack.STREAM_CODEC, MiniaturizationRecipe::catalyst, |
Collaborator
There was a problem hiding this comment.
Revert to ItemPredicate
| public static MiniaturizationRecipe fromCodec(int craftTime, int recipeSize, List<IRecipeLayer> layers, | ||
| MiniaturizationRecipeComponents components, List<ItemStack> outputs, | ||
| ItemPredicate catalyst) { | ||
| ItemStack catalyst) { |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.