Change Json regex to prevent timeout with partial json#43
Open
ogchrislem wants to merge 1 commit intoCommunityToolkit:mainfrom
Open
Change Json regex to prevent timeout with partial json#43ogchrislem wants to merge 1 commit intoCommunityToolkit:mainfrom
ogchrislem wants to merge 1 commit intoCommunityToolkit:mainfrom
Conversation
Json parsing can fail with incomplete json, and just timeout with no exception thrown. Adding the word boundary match to the regex prevents this. Unsure of any further implications but complete json is still parsed successfully after the change
Author
|
@dotnet-policy-service agree |
hoverwars
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Json parsing can fail with incomplete json, timing out with no exception thrown. Adding the word boundary match to the regex prevents this. Unsure of any further implications but complete json is still parsed and coloured successfully after the change
Example failing code before change using ColorCode via Markdig