Added a default timeout for parsing#4
Open
Foda wants to merge 2 commits intoCommunityToolkit:mainfrom
Open
Conversation
3b92274 to
f3e6bd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered an issue specifically with the CSS parsing regex where a line that doesn't end in a
}and is quite a long will cause an extremely long parsing time (more than a few mins).To fix this issue, I've added a
defaultParseTimeoutSecparameter to theCodeColorizerBaseclass that allows you to specify a default parse timeout. This allows aRegexMatchTimeoutExceptionto be thrown when callingLanguageParser.ParseHere's a minimal example of the issue:
Dotnetfiddle version (should take ~6 seconds to run, but adding more items will cause the time to go up very quickly)
Code: