NW6| Bakhat Begum| CODEWARS-API-PROJECTS | codeware-API-Project | WEEK-4 #15
NW6| Bakhat Begum| CODEWARS-API-PROJECTS | codeware-API-Project | WEEK-4 #15BakhatBegum wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-codewars-projects ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SpectacularLandscape
left a comment
SpectacularLandscape
left a comment
There was a problem hiding this comment.
Great work adapting the component, @BakhatBegum
Just be careful of some comments I have left.
This PR is also missing step 7, which asks for a new web component to be created. I'll move back into "Backlog" on your board so you can complete this last step.
| <body> | ||
| <codewars-badge></codewars-badge> | ||
| <div class="layout"> | ||
| <h1><span>6 kyu </span> BakhatBegum</h1> |
There was a problem hiding this comment.
Make sure you are using data from the API, not hard-coding in the HTML. Your rank will update over time so it needs to change. And if we use the JavaScript for the username, other people could use the page with their own username 🙂
There was a problem hiding this comment.
Great work making this project your own, Bakhat! Just be careful of formatting, it looks like Prettier hasn't formatted this CSS file
2 participants
Learners, PR Template
Self checklist
Changelist
The pull request is about fetch API, how it works and, what is a web component in HTML file is.
Questions
I would be very happy if you assist me by providing any video regarding fetch and async.