WM5 | ADNIYA YOUSAF | MODULE-JS-2 | CODEWARS-API-PROJECT | WEEK 4#11
WM5 | ADNIYA YOUSAF | MODULE-JS-2 | CODEWARS-API-PROJECT | WEEK 4#11adniyaYousaf wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-codewars-projects ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SallyMcGrath
left a comment
SallyMcGrath
left a comment
There was a problem hiding this comment.
Fabulous work @adniyaYousaf! I have some questions:
Why are there two web components here? Did you get blocked on how to pass a new name in on index.html?
Knowing what you know now about mapping over templates, how would you iterate on this design to show a leaderboard for your class?
| width:5rem; | ||
| } | ||
| </style> | ||
| <div class="container"> |
There was a problem hiding this comment.
Is there another semantic HTML tag that sections content?
| ${this.userData.ranks.overall.name} | ||
| </data> | ||
| <data value="${this.userData.name}">Name: | ||
| <span class="label">${this.userData.name}</span> |
There was a problem hiding this comment.
It looks to me like this is a description list or definition list.
Look into dl/dt/dd tags to group and structure this data
| flex-direction:column; | ||
| gap:1rem; | ||
| width:60%; | ||
| background:black; |
There was a problem hiding this comment.
When I ran Lighthouse, it gave me a colour contrast problem on this style. What did you get?
2 participants
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.