ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 5 | Prep Exercises#317
Open
Rashaad-Ebrahim wants to merge 17 commits intoCodeYourFuture:mainfrom
Open
ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 5 | Prep Exercises#317Rashaad-Ebrahim wants to merge 17 commits intoCodeYourFuture:mainfrom
Rashaad-Ebrahim wants to merge 17 commits intoCodeYourFuture:mainfrom
Conversation
Rashaad-Ebrahim
added
the
Needs Review
LonMcGregor
reviewed
Jan 21, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Have a look at the "files changed" tab - I think there are some changes here from other tasks
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
Could you find a way to recursively print a full family tree - including grandchildren?
There was a problem hiding this comment.
When i try to run this file at the command line I get an error, can you figure out why that happens and fix it?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Prep exercises completed
Questions
No questions at this time