Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 5 | Allocation Laptop#311
Open
Nataliia74 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 5 | Allocation Laptop#311Nataliia74 wants to merge 2 commits intoCodeYourFuture:mainfrom
Nataliia74 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Nataliia74
added
the
Needs Review
OracPrime
added
the
Review in progress
OracPrime
reviewed
Jan 6, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
I think the code will work, but it is way too complicated. Please follow-up on the suggestion for a much simpler approach. It's often slightly harder to right simpler code, but it's worth it for everyone else that has to work with the code afterwards.
OracPrime
added
Reviewed
Nataliia74
added
the
Needs Review
OracPrime
approved these changes
Jan 14, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
That is much easier to read, well done.
OracPrime
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
02 Implement laptop allocation issue 179