London | SDC-Nov-25 | Pezhman Azizi | Sprint 3 | Implement shell tools (cat, ls, wc) In JavaScript With NodeJS#302
Open
Pezhman-Azizi wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
LonMcGregor
reviewed
Jan 21, 2026
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Your way of handling arguments works ok, but can you think of any downsides to managing your arguments by checking each one in the input arguments? Compare this approach which how you handled arguments in the python task. Which is better?
| } | ||
|
|
||
| // Coursework only tests -1 variants, so enforce it clearly | ||
| if (!onePerLine) { |
There was a problem hiding this comment.
Is there a reason you only focus on -1 here?
| return { lines, words, bytes }; | ||
| } | ||
|
|
||
| function formatOutput(counts, fileName) { |
There was a problem hiding this comment.
Good idea to move this to its own function!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR adds JavaScript (NodeJS) implementations of the three shell tools required for the sprint: cat, ls, and wc.
Each tool is implemented in its own commit for clarity and easier review.
What's Included
cat.js
catls.js
-1(one entry per line)-a(show hidden files)fs.readdirSync()and simple filteringwc.js
-l,-w,-ctotallinefsfor UTF-8 byte counting📝 Notes
cat,ls,wc)