Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293
Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293HassanOHOsman wants to merge 97 commits intoCodeYourFuture:mainfrom
Conversation
…argument in open_account
|
There are a lot of files comitted here, can you take a look and figure out why that is happening? |
Yes, I just ignored the .venv so that it's easy for you to navigate through. Please let me know if you need anything else :) |
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these tasks, there are just two of them I have suggestions for improvements in
prep-exercises/exercise_nine.py
Outdated
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
This correctly prints out this person's children. Do you think there is a way to make it print out the whole family tree?
(hint: recursion)
There was a problem hiding this comment.
There was a problem hiding this comment.
Great work on this task so far. I was thinking about if, for example in that screenshot, if Aisha had a child as well (i.e. Imran's grandchild). Could you design the function in such a way that it could print that out as well? Recursion might help here.
There was a problem hiding this comment.
I now understand. Thank you for clarifying. Done as instructed. Please review and let me know if there's anything else that needs improving. I appreciate you help :)
… up with "None" for the selected/entered OS option by end-user
LonMcGregor
left a comment
There was a problem hiding this comment.
Very good work on this task! Good idea to add some extra indentation to improve the output. you are complete with this sprint now

Self checklist
This PR contains my solutions to all the "Prep Exercises" in Sprint 5 of the "Tools" module.