London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 4|Implement cowsay#290
Open
fatmaevin wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 4|Implement cowsay#290fatmaevin wants to merge 3 commits intoCodeYourFuture:mainfrom
fatmaevin wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
fatmaevin
added
📅 Sprint 4
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Dec 23, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start. I have left some comments. Also, can you include a requirements file so I know which library you intend to use?
implement-cowsay/cow.py
Outdated
| if animal not in animals: | ||
| print(f"Invalid animal. Supported animals are: {', '.join(animals)}") | ||
| exit(1) | ||
| cowsay.char_funcs[animal](args.text) |
There was a problem hiding this comment.
What happens if I give my arguments as plain text, without quotes?
Author
There was a problem hiding this comment.
Thanks for the feedback
I’ve updated the script to support multi-word text without quotes by using (nargs="+") for the text argument.
implement-cowsay/cow.py
Outdated
|
|
||
| parser = argparse.ArgumentParser(description="implement Cowsay command") | ||
| parser.add_argument("text", help="Text to be displayed") | ||
| parser.add_argument("--animal", help="Animal to say the text", default="cow") |
There was a problem hiding this comment.
Can you get the help to show the list of possible animals?
Author
There was a problem hiding this comment.
Thank you for your feedback. I’ve added a list of all cowsay animals to the help output so can see the available options.
LonMcGregor
added
Reviewed
fatmaevin
added
the
Needs Review
|
Great, this is almost complete. Can you check my earlier comment about requirements? |
LonMcGregor
removed
the
Needs Review
fatmaevin
added
the
Needs Review
|
Good work, this is complete now |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist