Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 4 |Implement Shell tools in python#256
Open
sheida-shab wants to merge 18 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 4 |Implement Shell tools in python#256sheida-shab wants to merge 18 commits intoCodeYourFuture:mainfrom
sheida-shab wants to merge 18 commits intoCodeYourFuture:mainfrom
Conversation
sheida-shab
commented
Nov 27, 2025
sheida-shab
commented
- I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
- My changes meet the requirements of the task
- I have tested my changes
- My changes follow the style guide
sheida-shab
changed the title
sheida-shab
added
Needs Review
eliza-an
added
Review in progress
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jan 21, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Remember to include a summary of changes in the PR
| print(item) | ||
| elif args.one : | ||
| if not item.startswith(".") : | ||
| print(item) |
There was a problem hiding this comment.
Did you test all the combinations of arguments?
Author
There was a problem hiding this comment.
Fix -a output order to match ls: non-hidden files first, hidden files last, with '.' and '..' at the top. Previously I tested all combinations and thought showing all files/folders was enough, but now I fixed the order to fully match ls behavior.
There was a problem hiding this comment.
If you test this without the -1 option, can you see what happens. What would you expect to happen?
Author
There was a problem hiding this comment.
Thanks for pointing this out. I hadn’t tested the code without the -1 flag, which helped me see a problem in my printing logic. I was wrongly using -1 to decide whether anything was printed, instead of only how the output should be shown.
LonMcGregor
added
Reviewed
sheida-shab
removed
the
Reviewed
sheida-shab
added
the
Needs Review
LonMcGregor
added
Reviewed
sheida-shab
added
Needs Review
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.