London | 26-ITP-Jan | Kris Oldrini | Sprint 2 | Form Controls #1140
+112
−25
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,114 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta | ||
| name="description" | ||
| content="Accessible t-shirt order form with colour and size selection." | ||
| /> | ||
| <title>My form exercise</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>T-shirt Picker</h1> | ||
| <p>Please complete all required (*) fields to complete order</p> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <fieldset> | ||
| <legend>Customer Info</legend> | ||
| <!-- name input, must be min 2 chars long --> | ||
| <p> | ||
| <label for="name"> Name *</label> | ||
| <input | ||
| type="text" | ||
| id="name" | ||
| name="customerName" | ||
| placeholder="Jane Smith" | ||
| minlength="2" | ||
| required | ||
| /> | ||
| </p> | ||
| <!-- email input, must be a valid email format --> | ||
| <p> | ||
| <label for="email"> Email *</label> | ||
| <input | ||
| type="email" | ||
| id="email" | ||
| name="customerEmail" | ||
| placeholder="jsmith@email.com" | ||
| pattern="^[\w.-]+@[\a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$" | ||
| required | ||
| /> | ||
| </p> | ||
| </fieldset> | ||
| <fieldset> | ||
| <legend>Colours</legend> | ||
| <!-- colours input, limit to 3 colours only --> | ||
| <p>Please select a colour *</p> | ||
|
There was a problem hiding this comment. We can make this, Screen readers announce legends, not surrounding text.
Author
There was a problem hiding this comment. I will do that, thank you. I just have a question: does it mean that radio buttons should always be inside a fieldset? Because I don't think I can create a "group" label, only one for each input. Unless there's another trick I could not find. |
||
| <ul> | ||
| <li> | ||
| <p> | ||
| <input | ||
| type="radio" | ||
| name="colours" | ||
| id="red" | ||
| value="red" | ||
| required | ||
| /> | ||
| <label for="red"> 🟥 Red </label> | ||
| </p> | ||
| </li> | ||
| <li> | ||
| <p> | ||
| <input | ||
| type="radio" | ||
| name="colours" | ||
| id="blue" | ||
| value="blue" | ||
| /> | ||
| <label for="blue">🟦 Blue </label> | ||
| </p> | ||
| </li> | ||
| <li> | ||
| <p> | ||
| <input | ||
| type="radio" | ||
| name="colours" | ||
| id="yellow" | ||
| value="yellow" | ||
| /> | ||
| <label for="yellow">🟨 Yellow </label> | ||
| </p> | ||
|
There was a problem hiding this comment. The pattern like below is not needed, we can have cleaner, this goes to some places on top as well
Author
There was a problem hiding this comment. Absolutely agree. I wouldn't normally add a inside a list item, but Lighthouse was not happy with the list's tiny spacing, and, because I could not use CSS, I tried to improvise. |
||
| </li> | ||
| </ul> | ||
| </fieldset> | ||
| <fieldset> | ||
| <legend>Size</legend> | ||
| <p> | ||
| <!-- size input, limit to 6 sizes: XS, S, M, L, XL, XXL --> | ||
| <label for="size">Please select a size *</label> | ||
| <select name="size" id="size" required> | ||
| <option value="" disabled selected>size</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </p> | ||
| </fieldset> | ||
|
|
||
| <!-- submit button --> | ||
| <p><button type="submit">Confirm your order</button></p> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>Kris Oldrini | CYF: Intro to Programming</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\a is invalid inside character class
Browsers already validate emails using: type="email"
you can remove the pattern completely
<input type="email" ... required />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, that was a missed typo. I've corrected it now, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you say remove the pattern do you mean for this specific sprint or in general?