Birmingham | 26-ITP-Jan | Merve Reis | Sprint 1 | Wireframe

[mervereis]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I transformed wireframe to an html page.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	4c7451d
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/698505d20527e400084ed22b
😎 Deploy Preview	https://deploy-preview-1118--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Code is free of syntax errors and well indented. Well done!

1

When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you
- Align the height of the image in articles 2 and 3? (In the wireframe they have the same height)

2

The footer content is not quite centered. Can you make it "more center"?

Note: The gap between articles 2 and 3 should be on the center of the page.

Optional change

The spacing in the second article appears to be slightly different from that in the third. In particulars,

• The vertical gap before and after the article title
• The margin/padding size around the "Read More" link
  With the original CSS, this spacing issues appears to be affected by the content length. Can you modify the CSS code to make the spacing more consistent in all articles regardless of content length?

[mervereis]

@cjyuan I made the changes thank you for feedback.

[cjyuan]

I don't see any new commits on this branch. Did you forget to push the changes to GitHub, or have you made the changes you on a different branch?

Please note in ITP, when your PR is ready to be re-reviewed, you should also add a "Needs review" label to the PR in addition to responding to reviewer's feedback.

[mervereis]

sorry I sent them wrong pr I changed now and added needs review label.Thanks for your feedback @cjyuan