generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 417
Sheffield | 26-Jan -ITP | Hayriye Saricicek | Sprint 2 | Form Control #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mshayriyesaricicek
wants to merge
7
commits into
CodeYourFuture:main
Choose a base branch
from
mshayriyesaricicek:Feature-formcontrol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
69dea0a
put labels in and ensured, complete min 2char, , choices selected and…
mshayriyesaricicek 830554a
amended checklist and added a few coments to make it more understanda…
mshayriyesaricicek 3271f51
comments were showing so corrected so longer showing
mshayriyesaricicek d62e4ad
Merge branch 'CodeYourFuture:main' into Feature-formcontrol
mshayriyesaricicek a6a55f5
i have made amendments to names to use patter, replaced p with div, m…
mshayriyesaricicek ca2fc3a
Merge branch 'CodeYourFuture:main' into Feature-formcontrol
mshayriyesaricicek 27a9afc
Merge branch 'Feature-formcontrol' of https://github.com/mshayriyesar…
mshayriyesaricicek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,19 +9,87 @@ | |
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| <h1>Amazing T-shirts</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <form> | ||
| <! -- User Personal Information Section --> | ||
| <div> | ||
| <p><label for="firstName">First Name:</label> | ||
| <input type="text" pattern="^[A-Za-z]{2,}$" id="firstName" name="firstName" autocomplete="on" minlength="2" autofocus> </p> | ||
| <p><label for="lastName">Last Name:</label> | ||
| <input type="text" pattern="^[A-Za-z]{2,}$" id="lastName" name="lastName" autocomplete="on" minlength="2" required></p> | ||
| <p><label for="email">Email:</label> | ||
| <input type="email" id="email" name="email" autocomplete="on"></p> | ||
| </div> | ||
|
|
||
| <h2><strong>T-Shirt Size:</strong></h2> | ||
| <div> | ||
| <label> | ||
| <input type="radio" name="size" value="XS" required> | ||
| Extra Small | ||
| </label> | ||
| <br><br> | ||
| </div> | ||
| </div> | ||
| <label> | ||
| <input type="radio" name="size" value="S" required> | ||
| Small | ||
| </label> | ||
| <br><br> | ||
| </div> | ||
| <div> | ||
| <label> | ||
| <input type="radio" name="size" value="M" required> | ||
| Medium | ||
| </label> | ||
| <br><br> | ||
| </div> | ||
| <div> | ||
| <label> | ||
| <input type="radio" name="size" value="L" required> | ||
| Large | ||
| </label> | ||
| <br><br> | ||
| </div> | ||
| <div> | ||
| <label> | ||
| <input type="radio" name="size" value="XL" required> | ||
| Extra Large | ||
| </label> | ||
| <br><br> | ||
| </div> | ||
|
|
||
| <h2><strong>Color Preference:</strong></h2> | ||
| <div> | ||
| <label> | ||
| <input type="radio" name="color" value="red" required> | ||
| Red | ||
| </label> | ||
| <br><br> | ||
| </div> | ||
| </div> | ||
| <label> | ||
| <input type="radio" name="color" value="blue" required> | ||
| Blue | ||
| </label> | ||
| <br><br> | ||
| </div> | ||
| <div> | ||
| <label> | ||
| <input type="radio" name="color" value="black" required> | ||
| Black | ||
| </label> | ||
|
Comment on lines
+65
to
+82
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: These radio buttons belong to the same group (same |
||
| <br><br> | ||
| </div> | ||
|
|
||
| <! -- Submit Button --> | ||
| <button type="submit">Submit</button> | ||
|
|
||
| </form> | ||
| </main> | ||
|
|
||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| </footer> | ||
| </body> | ||
| <p>Contact: Hayriye Saricicek <a href="mailto:mshayriyesaricicek@gmail.com">mshayriyesaricicek@.com</a></p> | ||
| </footer> </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These input elements are also wrapped inside the paragraph elements (and not
<div>).Suggestion: Try the "replace all" feature in VSCode.