generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 30
WestMidlands | SDC NOV 2025| Sara Tahir | Sprint 1| Hashtag Slowing Down my Browser #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SaraTahir28
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
SaraTahir28:Legacy/prep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−6
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "liveServer.settings.root": "front-end/", | ||
| "python.defaultInterpreterPath": "backend/.venv/bin/python" | ||
| "python.defaultInterpreterPath": "backend/.venv/bin/python", | ||
| "liveServer.settings.port": 5501 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { test, expect } from "@playwright/test" | ||
|
|
||
|
|
||
| test("should not make infinite hashtag endpoint requests", async ({ page }) => { | ||
| // ===== ARRANGE | ||
| const requests = []; | ||
| page.on("request", (request) => { | ||
| if ( | ||
| request.url().includes(":3000/hashtag/do") && | ||
| request.resourceType() === "fetch" | ||
| ) { | ||
| requests.push(request); | ||
| } | ||
| }); | ||
| // ====== ACT | ||
| // When I navigate to the hashtag | ||
| await page.goto("/#/hashtag/do"); | ||
| //Wait for the UI to show the blooms have loaded | ||
| await page.locator("[data-bloom]").first().waitFor(); | ||
|
|
||
| // ====== ASSERT | ||
| // Then the number of requests should be 1 | ||
| expect(requests.length).toEqual(1); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@illicitonion I have changged the function here in this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I still see
state.currentHashtag = formattedHashtag;on line 22 - was the point not to remove that line?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understood from your first comment is that I updated state.currentHashtag immediately but state.hashtagBlooms still contained the old blooms so there was a possibility of UI showing mismatched data.
I replace it with updating state.currentHashtag when the hashtag actually changes.
The fix was just to store the formatted hashtag so the comparison works properly and the UI only updates when the data actually changes.
if I removed this line state.currentHashtag = formattedHashtag state.currentHashtag would never get updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getBloomsByHashtagalready updatesstate.currentHashtagwhen it gets results. AndcurrentHashtagis currently read inviews/hashtag.mjsfor deciding what hashtag heading to show.If we just let
getBloomsByHashtagdo the update, we make surecurrentHashtagandhashtagBloomsare always in sync. If you manually updatecurrentHashtag, then someone triggers a re-render, we'll show the new hashtag but the old blooms.