Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 |Extra long blooms#105
Open
sheida-shab wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 |Extra long blooms#105sheida-shab wants to merge 4 commits intoCodeYourFuture:mainfrom
sheida-shab wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
sheida-shab
added
Needs Review
illicitonion
reviewed
Feb 4, 2026
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks good, but it looks like you have fixes for other problems in this same PR - please only include one fix per PR
Comment on lines
+162
to
+163
| if len(content)>280 : | ||
| return jsonify({"success": False, "error": "Bloom must be 280 characters or less"}), 400 |
Member
There was a problem hiding this comment.
If we wanted to change the limit to 300 in the future, we'd need to edit multiple values in this file. How could we avoid this?
Comment on lines
+199
to
+200
| if (content.length>280){ | ||
| handleErrorDialog(new Error("Bloom must be 280 characters or less")); |
Member
There was a problem hiding this comment.
If we wanted to change the limit to 300 in the future, we'd need to edit multiple values in this file. How could we avoid this?
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description :
Fix Bloom length validation (max 280 chars)