LONDON | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 3 | Middleware#66
Open
zohrehKazemianpour wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
LONDON | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 3 | Middleware#66zohrehKazemianpour wants to merge 3 commits intoCodeYourFuture:mainfrom
zohrehKazemianpour wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You must title your PR like this:
Region | Cohort | FirstName LastName | Sprint | Assignment Title
Learners, PR Template
Self checklist
Changelist
I finished the middleware exercise. I made two versions to show the difference:
app.js: I wrote my own parser using req.on('data') and req.on('end'). This helps me understand how Node.js actually receives data chunks.
app-builtin.js: I swapped my manual code for express.json().
I spent some time debugging the curl commands. I found out that:
My manual parser was accepted anything.
express.json() is more strict. It only works if I add the -H "Content-Type: application/json" header to the curl command.
Logic included
I also added code to check if the user is authenticated with X-Username and made sure the response handles plural words correctly.