London | Rihanna Poursoltani | Module-Decomposition | Sprint 4 | Laptop allocation#57
Open
RihannaP wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
London | Rihanna Poursoltani | Module-Decomposition | Sprint 4 | Laptop allocation#57RihannaP wants to merge 4 commits intoCodeYourFuture:mainfrom
RihannaP wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
LonMcGregor
reviewed
Oct 28, 2025
LonMcGregor
left a comment
There was a problem hiding this comment.
Hi, there are far too many files committed here for this task. Can you take another look at this PR and make sure you're only committing what is necessary?
This reverts commit 94faa6d.
LonMcGregor
reviewed
Oct 29, 2025
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist