ZA | 25-SDC-July | Luke Manyamazi | Sprint 4 | Prep Exercises#41
Open
Luke-Manyamazi wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
ZA | 25-SDC-July | Luke Manyamazi | Sprint 4 | Prep Exercises#41Luke-Manyamazi wants to merge 2 commits intoCodeYourFuture:mainfrom
Luke-Manyamazi wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Luke-Manyamazi
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Oct 29, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
|
|
||
| print(double("22")) | ||
|
|
||
| # I somehow expected it to return this answer, because the string "22" doubled is "2222" No newline at end of file |
There was a problem hiding this comment.
Is this behaviour consistent for all inputs (think about possible types of input). Are there any changes you would suggest making to prevent bugs from happening if this function were used incorrectly?
|
|
||
| imran = Person("Imran", 22, "Ubuntu") | ||
| print(imran.name) | ||
| # print(imran.address) # Person has no address attribute |
There was a problem hiding this comment.
Could you suggest a change that would fix this error?
| self.preferred_operating_system = preferred_operating_system | ||
|
|
||
| @property | ||
| def age(self) -> int: |
There was a problem hiding this comment.
What is a benefit or drawback of writing a function this way?
| class Person: | ||
| name: str | ||
| children: List["Person"] | ||
| age: int |
There was a problem hiding this comment.
Can you solve this in a way that it always prints the current age, rather than hard-coding a specific age?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all the Python Prep Exercises
Questions
None