West Midlands | July SDC | Gabriel Deng | Sprint 4 | Prep exercises by gai93003 · Pull Request #39 · CodeYourFuture/Module-Decomposition

gai93003 · 2025-10-20T14:14:58Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

…instances

… object

…e list

github-actions · 2025-10-20T14:15:14Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:15:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:15:38Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:15:38Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:15:38Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:15:38Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:15:46Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:15:48Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T14:23:59Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor

Remember to leave a summary of what work you've done in the PR body on github.

You don't need to commit the__pycache__ directory

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

LonMcGregor · 2025-10-29T10:19:34Z

prep exercises/test.py

@@ -0,0 +1,5 @@
+def double(n): 
+    return n * 3


Does this function actually double? What change could you make to resolve the issue?

I think for this function, there are two possible interpretations. Firstly, the function might have been meant to return the triple value of n. In this case, I could the function name from double(n) to triple(n). Secondly, the function might actually been meant to return double the value of n. Meaning I can just change the 3 to 2.

LonMcGregor · 2025-10-29T10:26:17Z

prep exercises/bank_account.py

@@ -0,0 +1,30 @@
+def open_account(balances, name, amount):


Part of the bank account task involved making type annotations, can you try that?

I have just added the type annotations on the functions

LonMcGregor · 2025-10-29T10:31:16Z

prep exercises/dataclasses_exercise.py

did you try running the code and spotting what the error was?

LonMcGregor · 2025-10-29T10:35:25Z

prep exercises/objects_and_classes.py

+        self.preferred_operating_system = preferred_operating_system
+        self.address = address
+
+    def is_adult(self):


What is a benefit or drawback of writing the function this way?

Writing a method has many benefits, such as it helps in encapsulating logic, as a result, it makes the method reusable in other instances of the class. The problem of these functions is that they become difficult to test in isolation as compared to free functions.

LonMcGregor · 2025-10-29T10:39:35Z

prep exercises/dataclasses_exercise.py

+    def is_adult(self):
+        today_date = date.today()
+        birth_date = date.fromisoformat(self.date_of_birth)
+        age = today_date.year - birth_date.year


Would this date calculation work all the time? What about if they are one day away from a 18th birthday in the current year?

This calculation will not work in this scenario because I am only comparing the years. I have changed the functionality to include the days instead of only comparing the years

LonMcGregor · 2025-10-29T10:47:01Z

prep exercises/generic_exercise.py

+class Person:
+    name: str
+    children: List["Person"]
+    age: int


Can you solve this in a way that it always prints the current age, rather than hard-coding a specific age?

I have changed the age to date_of_birth and used the function i used previous to calculate the age of the person as long as the birthday is given.

LonMcGregor · 2025-11-03T11:59:00Z

Good work, I think this is complete now

github-actions · 2025-11-03T11:59:17Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T11:59:21Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

gai93003 added 3 commits October 17, 2025 21:42

I just used datetime in a class to calculate the age of person class …

d7b5b7a

…instances

I used dataclass to help shortened my code and define the type of the…

c172120

… object

Used list imported from typing to specify the type of the items in th…

8e2f3ce

…e list

gai93003 added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Decomposition The name of the module. labels Oct 20, 2025

LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Oct 29, 2025

LonMcGregor reviewed Oct 29, 2025

View reviewed changes

gai93003 added 3 commits November 1, 2025 16:12

I have added type annotation on the function

63968ad

These are the changes i made in method is_adult()

9b3ad1e

I made the ages to be dynamically calculated

fe955b3

LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 3, 2025

Uh oh!

Conversation

gai93003 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gai93003 commented Oct 20, 2025 •

edited

Loading