West Midlands | 25-SDC-July | Gabriel Deng | Sprint 2 | Implement and LRU cache in Python#84
Open
gai93003 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
West Midlands | 25-SDC-July | Gabriel Deng | Sprint 2 | Implement and LRU cache in Python#84gai93003 wants to merge 1 commit intoCodeYourFuture:mainfrom
gai93003 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gai93003
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
gai93003
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
gai93003
added
the
Needs Review
cjyuan
reviewed
Jan 25, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
To better follow the Single-Responsibility Principle (SRP) in SOLID design principles,
it would be better to implement the "doubly linked list" and the "LruCache" as two separate classes, and then use the linked list in LruChache to enforce order.
Alternatively, use OrderedDict in your solution.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist