Conversation
|
Hello there @SumayaT, |
|
Remember you can check out the Git cheatsheet - pay particular attention to the section I want to send my code to volunteers (Pushing). This section gives instructions on how to format your PR title. |
Dedekind561
left a comment
Dedekind561
left a comment
There was a problem hiding this comment.
Well done on your first submission for the JS coursework!
Just added a few comments here for you to think about.
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(number) { | ||
| let currency = calculateSalesTax(number); |
There was a problem hiding this comment.
Is currency the best name for this variable here? What does the output of the function calculateSalesTax represent? Thinking of how to answer this question will help you to improve your variable name.
| let total = a + b; | ||
|
|
||
| return "The total is total"; | ||
| return "The total is " + total; |
There was a problem hiding this comment.
Can you try refactoring line 14 to make use of template literals?
| function multiply(a, b, c) { | ||
| a * b * c; | ||
| return; | ||
| return a * b * c; |
There was a problem hiding this comment.
👓 Watch out for your indentation here.
2 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?