Indent wrapped lines (CodeEditTextView #18): settings, UI, tests; git… #2158
+96
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests; git status skip unknown types; lint fixes - Add wrappedLineIndent setting and UI in Text Editing preferences - Add TextEditingSettingsTests for wrapped line indent - GitClient+Status: skip unknown porcelain v2 entry types instead of throwing - Lint: shorten doc comment, strip trailing whitespace in WorkspaceView - CodeFileView: pass wrappedLineIndent when using local CodeEditSourceEditor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… status skip unknown types; lint fixes
Description
Adds support for indent wrapped lines (CodeEditTextView #18) from the CodeEdit side: a new preference and UI so users can choose how many spaces to indent continuation lines when line wrapping is on (e.g. 4 or 12, like Xcode).
The actual wrapping/indent behaviour is implemented in CodeEditTextView/CodeEditSourceEditor; this PR adds the setting and wires it through when those packages expose the API.
Related Issues
Addresses CodeEditTextView #18 (Indent wrapped lines) from the CodeEdit app side (settings + UI). The underlying feature is implemented in CodeEditTextView and CodeEditSourceEditor; this PR adds the preference and passes it through.
Checklist
Screenshots