Add simple safeguarded compressor wrappers for BitRound, ZFP, SZ3, and SPERR#56
Open
Add simple safeguarded compressor wrappers for BitRound, ZFP, SZ3, and SPERR#56
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
@treigerm The safeguards have their first public alpha release on PyPi now, so this is ready for our debugging session tomorrow |
juntyr
changed the title
5 tasks
Collaborator
Author
|
@treigerm This is now ready again, please completely remove the |
Collaborator
Author
|
Also, please include all safeguarded compressors (safeguarded-bitround-pco, safeguarded-zfp-round, safeguarded-sz3, safeguarded-sperr, safeguarded-zero, safeguarded-zero-dssim). Thanks! |
juntyr
changed the title
Collaborator
Author
juntyr
changed the title
Collaborator
Author
|
While the Safeguarded(0, dSSIM) compressor works as expected on 2D data, it fails once we have different height levels, since analysis quantises over the 2D min-max range, but the safeguards are only given the global ones. This could be done by threading through the per-2D level range ... let's see if I can make it work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds (simple) safeguarded (https://github.com/juntyr/compression-safeguards) variants for the BitRound+PCO, ZFP-ROUND, SZ3, and SPERR compressors