This repository was archived by the owner on Aug 5, 2025. It is now read-only.
fix: pass variables to langchain messages on prompt rendering#172
Open
asvishnyakov wants to merge 1 commit intoChainlit:mainfrom
Open
fix: pass variables to langchain messages on prompt rendering#172asvishnyakov wants to merge 1 commit intoChainlit:mainfrom
asvishnyakov wants to merge 1 commit intoChainlit:mainfrom
Conversation
Member
Author
|
Fixes #171 |
Member
Author
|
@willydouhard May you take a look? |
Member
Author
|
@willydouhard Do you accept PRs to this project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when any additional messages passed to Literal AI prompt, converted using
to_langchain_chat_prompt_templateinto LangChain prompt template will not receive variableshistorywill not be renderedP.S. This code looks very suspicious, I would say we should simply render with custom formatter first N messages which come from the prompt and then use default for the rest (additional) instead of catching exception, but this PR fixes an issue with minimal changes in code.