[SHARE-777][Feature][HOLD] Add tind.io harvester for AgEcon#667
[SHARE-777][Feature][HOLD] Add tind.io harvester for AgEcon#667aaxelb wants to merge 2 commits intoCenterForOpenScience:developfrom
Conversation
aaxelb
force-pushed
the
feature/agecon-update
branch
from
0697cc4 to
c607117
Compare
laurenbarker
left a comment
laurenbarker
left a comment
There was a problem hiding this comment.
Just took a quick look since it's on hold 💯
share/transformers/mods.py
Outdated
| tools.Try(ctx['mods:identifier']), | ||
| tools.Try(ctx.header['identifier']) | ||
| tools.Try(ctx.header['identifier']), | ||
| tools.Try(ctx['mods:location']['mods:url']), |
There was a problem hiding this comment.
@aaxelb, do you want to pull the location url stuff into another PR since this one is on hold and also resolves https://openscience.atlassian.net/browse/SHARE-861?
There was a problem hiding this comment.
Makes sense, will do.
| @@ -1,138 +0,0 @@ | |||
| import re | |||
There was a problem hiding this comment.
Do we want to remove the old transformer? If we re-transform the old data we will still need this code.
There was a problem hiding this comment.
Hmm, I'd kinda rather it be removed, since we'll never get new data for it, but I didn't think about the old data. I'll put it back in for now.
There was a problem hiding this comment.
In the same spirit, I restored the old source config (disabled and with no harvester) so the system knows what to do with the old data.
2 participants
edu.ageconsearchharvester and transformerio.tindharvester we could use for any source using Tind IR (from their press releases, looks like just AgEcon so far)Waiting on a fix on filtering by date range.