Conversation
|
I really like this idea, but I think we could expand it quite a bit. An idea is perhaps to split from Bukkit's event system and create our own, and have modules listen to that rather than Bukkit's event channels. We could implement inheritance-based event listening, like sponge's event system. And we could allow any module to attatch metadata to the event as well. |
|
@twizmwazin could you expand upon what you mean by inheritance-based event listening. I don't follow |
|
@ElliottWhyman where you can have a listener for "PlayerEvent" and it will be called with any event that extends player event |
|
Oh I see, we should definitely look into our event bus system |
|
The argument against our own system is that it disregards Bukkit's system. |
|
perhaps just some changes upstream in sportbukkit to make it work the way we would like it whilst keeping the pre existing bukkit integration |
A small idea we could implement, would make it easier for us, since we can pass helpful information into the event directly, like the match that event corresponds to, or maybe pass the team (player container) the player that triggered that event is in, instead of trying to get that information in every module independently