Open
Conversation
cdhinrichs
force-pushed
the
detX_plot_fixup
branch
from
1f83d6c to
afcf370
Compare
… check in valid_params
…pected number of plots
…pected number of plots
cdhinrichs
force-pushed
the
detX_plot_fixup
branch
from
afcf370 to
cfec958
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
ww_layer.namewas not being passed to fit_powerlaw, meaning that the plot titles were only showing layer plot_id, not layer name;detX_deltain apply_detX;test_column_names_analyze_detXso that it expects the new column.NOTE: This branch is currently based off of the other branch
separate_plots. Please do NOT merge this branch until that other PR is merged.All tests are passing, except for those that fail in master. The following have been skipped due to runtime:
Test_VGG11_Distances
Test_VGG11_Base
Test_VGG11_StateDict
Test_VGG11_Alpha_w_PowerLawFit