Open
Conversation
c5d93e0 to
b34af15
Compare
Contributor
Author
|
The bug was that there was a clause for overlaying the pdf plot on top of the log-log ESD. When I examined the code, it looked like that code was intended to run unconditionally whenever anything gets plotted, because it was interwoven with the clause for computing |
b34af15 to
f7193c2
Compare
… check in valid_params
…pected number of plots
f7193c2 to
53d8de9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #292
This PR does the following:
plotargument toWeightWatcher.analyze()and other entry points to take either a boolean argument, which is replaced with the list of ALL plots ifTrue, else an empty list; or to take a list of valid plot constants from the list abovevalid_params()to ensure the plot argument only has allowed constants in itparams[PLOT]list orplotargument, whichever argument is passed to the function where plotting takes place.safedir.The following tests are currently passing, or else have the same failures as in the
masterbranch:The following tests have been skipped due to runtime: