Refactor ml_translatorLib #1283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have not tested it |
Contributor
Author
|
I do know that (dest_const tm |> fst) and term_to_string tm differ on |
Contributor
|
Can you at least test it on |
ordinarymath
added
the
test failing
ordinarymath
force-pushed
the
translator_refactor1
branch
from
2a3a239 to
96f8817
Compare
ordinarymath
force-pushed
the
translator_refactor1
branch
from
c4c92f1 to
28227a3
Compare
It's slow and also the output of term_to_string can change with overloads
REWR_CONV does work when partially applied.
The old way made it such that recursive hol2deep errors were caught.
These were deleted in the recursive case but not in the non recursive case
This commit is just to move alist_treeLib to fix the perf issues with the code and it should be reupstreamed
ordinarymath
force-pushed
the
translator_refactor1
branch
from
bc56802 to
1a189ee
Compare
ordinarymath
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's slow and also the output of term_to_string
can change with overloads