Open
Conversation
… not working) Issue BuildmLearn#53
ravirnjn88
changed the title
Contributor
|
Wow, nice job. |
src/miscellaneous/iofactory.cpp
Outdated
Contributor
There was a problem hiding this comment.
Please, solve those #includes correctly. QMediaPlayer class is only available in Qt5. You commented out QSound usages, therefore QSound #ïnclude is not needed anymore. You could for example replace line 43 with line 38.
Contributor
Author
|
I have checked the toolkit with Qt4, mp3 files were playing correctly. |
Contributor
|
@ravirnjn88 OK, try this. Compile toolkit (in release mode with qt4) as you usually do. Then run "make install". Then go to "make install" output folder and run toolkit via the exe file. Then try if mp3 is running correctly. Once you confirm it does, I will merge. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous api of http://mary.dfki.de:59125 is not working. Change it to free api provided by http://tts-api.com (Issue #53 )