Fix MobX decorator incompatibility: switch to TC39 stage 3 decorators #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 decorators The esbuild config in build.ts was emitting legacy TypeScript decorators (__decorateClass), but MobX 6.15 expects TC39 stage 3 decorators, causing "context.addInitializer is not a function" at runtime. - Set experimentalDecorators: false in build.ts esbuild config - Fix 11 source files that mixed @decorator syntax with makeObservable annotation args (not allowed with TC39 decorators) - Use @observable accessor for non-serializable classes - Use all-annotations approach for AxisConfig/ChartDimension to preserve Object.keys() serialization compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add build:packages step before test step in CI so build.test.ts can import from dist/ (which is gitignored and not available in CI) - Add --stats-json to storybook build so Chromatic TurboSnap can find preview-stats.json Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
context.addInitializer is not a functionruntime error caused by esbuild emitting legacy TypeScript decorators (__decorateClass) while MobX 6.15 expects TC39 stage 3 decoratorsexperimentalDecorators: falseinbuild.tsesbuild config so decorators are emitted as native TC39 syntax@decoratorsyntax withmakeObservable(this, { annotations })— not allowed with TC39 decorators:SelectionArray,MapChart,SlideInDrawer,Footer,StackedBarSegment,StackedBarChart,StackedDiscreteBarChart,MarimekkoChart,ExplorerDecisionMatrix): converted observable fields to@observable accessorand changed tomakeObservable(this)AxisConfig,ChartDimension): used all-annotations approach to preserveObject.keys()serialization compatibility in Persistable classesTest plan
bun run buildsucceedsbun run typecheckpasses__decorateClasscalls🤖 Generated with Claude Code