-
Notifications
You must be signed in to change notification settings - Fork 25
Represent lichess as a compose container stack #27
base: master
Are you sure you want to change the base?
Conversation
afbc2d9 to
c752579
Compare
|
Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile |
|
Overhaul I'd like to say this looks very nice! Also well documented PR. |
I understand your idea. The whole point though is to not reinvent the wheel. If someone is uncomfortable, (s)he can re-generate the image locally with its own settings. |
c752579 to
2cd8877
Compare
|
This is much cleaner and easier to understand. Prior to this I was uncomfortable with the existence of many scripts like build/node-init.sh and build/sdkman-init.sh which appeared unnecessarily complex to me since I never had to use them to setup my own lila development environment per instructions. |
@gmolaire Wouldn't it be more appropriate to include those images in the same repository? I agree that it would be good to keep this self-contained and not depend on an external image. |
I don't think security is the real concern nor isolation, but I do see a potential need for the build tools to change and make the external images become irrelevant. I will adjust to allow the compose to start from build tools generated locally. |
ce2c158 to
0df060b
Compare
- Cleanup of unnecessary files - Decoupling of mongodb and redis as separate services - Use a base container containing the necessary build tools for lila and lila-ws - Update the README to match the changes closes BrandonE#15
0df060b to
a08c4fd
Compare
#15