Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Conversation

@gmolaire
Copy link

@gmolaire gmolaire commented Aug 8, 2020

  • Cleanup of unnecessary files
  • Decoupling of mongodb and redis as separate services
  • Use a base container containing the necessary build tools for lila and lila-ws
  • Update the README to match the changes

#15

@gmolaire gmolaire force-pushed the feature/add-docker-compose branch from afbc2d9 to c752579 Compare August 8, 2020 16:25
@kraktus
Copy link
Contributor

kraktus commented Sep 3, 2020

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools.

Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile
I think it should be added to the Dockerfile 👍

@kraktus
Copy link
Contributor

kraktus commented Sep 3, 2020

Overhaul I'd like to say this looks very nice! Also well documented PR.

@gmolaire
Copy link
Author

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools.

Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile
I think it should be added to the Dockerfile

I understand your idea. The whole point though is to not reinvent the wheel. If someone is uncomfortable, (s)he can re-generate the image locally with its own settings.

@gmolaire gmolaire force-pushed the feature/add-docker-compose branch from c752579 to 2cd8877 Compare September 19, 2020 18:17
@RogerThiede
Copy link

This is much cleaner and easier to understand. Prior to this I was uncomfortable with the existence of many scripts like build/node-init.sh and build/sdkman-init.sh which appeared unnecessarily complex to me since I never had to use them to setup my own lila development environment per instructions.

@BrandonE
Copy link
Owner

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools.

Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile
I think it should be added to the Dockerfile 👍

@gmolaire Wouldn't it be more appropriate to include those images in the same repository? I agree that it would be good to keep this self-contained and not depend on an external image.

@gmolaire gmolaire closed this Jan 22, 2021
@gmolaire gmolaire reopened this Jan 22, 2021
@gmolaire
Copy link
Author

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools.
Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile
I think it should be added to the Dockerfile +1

@gmolaire Wouldn't it be more appropriate to include those images in the same repository? I agree that it would be good to keep this self-contained and not depend on an external image.

I don't think security is the real concern nor isolation, but I do see a potential need for the build tools to change and make the external images become irrelevant. I will adjust to allow the compose to start from build tools generated locally.

@gmolaire gmolaire force-pushed the feature/add-docker-compose branch from ce2c158 to 0df060b Compare April 27, 2021 20:07
- Cleanup of unnecessary files
- Decoupling of mongodb and redis as separate services
- Use a base container containing the necessary build tools for lila and lila-ws
- Update the README to match the changes

closes BrandonE#15
@gmolaire gmolaire force-pushed the feature/add-docker-compose branch from 0df060b to a08c4fd Compare April 27, 2021 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants