added the step of validating the adaptor signature#33
Open
ChrisSon15 wants to merge 2 commits intoBlockstreamResearch:masterfrom
Open
added the step of validating the adaptor signature#33ChrisSon15 wants to merge 2 commits intoBlockstreamResearch:masterfrom
ChrisSon15 wants to merge 2 commits intoBlockstreamResearch:masterfrom
Conversation
+ mentined the 2nd adaptor necessary for swaps.
jonasnick
reviewed
Sep 25, 2024
Collaborator
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
Hi @ChrisSon15, I agree it makes sense to mention the adaptor signature verification step explicitly. However, I'm not sure about your proposed changes. I think the original proposal for atomic swaps used only a single adaptor signature.
… the 2 changes (an discuss seperately). So now it PR only has the change the B verifies the adaptor signature
Author
|
Hi @jonasnick , Sorry for combining 2 changes into one. To separate them I changed this PR to only add the adaptor signature verification step explicitly. As for the need of 2 adaptor signatures for s swap I may put it into another issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atomic swap was missing the step of validating the adaptor signature. IMHO, This should be added as otherwise it would be misleading to readers who seek education on this subject. I saw the warning sign, but I think, if you describing in a high level, then at least the high level would have all required steps. Also I made it a bit clearer that there is a second adaptor signature for the swap. Please consider reviewing.