Runnable with both Python3 and Python2, with both PyQt5 and PyQt4 by using Qt.py#2250
Open
kashikoibumi wants to merge 127 commits intoBitmessage:v0.6from
Open
Runnable with both Python3 and Python2, with both PyQt5 and PyQt4 by using Qt.py#2250kashikoibumi wants to merge 127 commits intoBitmessage:v0.6from
kashikoibumi wants to merge 127 commits intoBitmessage:v0.6from
Conversation
QtPy is a compatibility layer which allows to use the code written for PyQt5 with any python Qt binding: PyQt4, PyQt5, pyside or pyside2. Main differences in PyQt5: - all widget classes are now in QtWidgets package, not QtGui; - QString obsoleted by unicode (sip API 2); - changed the way of signals connection. Closes: Bitmessage#1191
customwidgets in ui-files and QtGui.QPen instantiation
- added Qt API string into support request - finished flake8 formatting
(for simple encoding like for extended)
(closes Bitmessage#897, closes Bitmessage#1418)
resolved pylint redefined-variable-type warnings, marked autogenerated modules for skipping by pylint and flake8
on tabs "Send", "Blacklist" and "Network Status": in qt5 it's probably true by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runnable with both Python3 and Python2, with both PyQt5 and PyQt4 by using Qt.py.