This repository was archived by the owner on Jan 23, 2024. It is now read-only.
update passwords and schema for splited keys and create tx to multiple address through a json string#3
Open
velasquez wants to merge 10 commits intoBitGo:masterfrom
Open
update passwords and schema for splited keys and create tx to multiple address through a json string#3velasquez wants to merge 10 commits intoBitGo:masterfrom
velasquez wants to merge 10 commits intoBitGo:masterfrom
Conversation
added 10 commits
February 14, 2016 16:34
…and scheme of splited key in json file generated by splitkeys
Author
|
This PR now includes another feature: 'createtxfromjson' which is explained in the README.md Please let me know what you comsider should be completed/changed to merge this changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an addition I did to bitgo-cli to allow change passwords and schema (m of n) of previosuly created splited keys. This is important to be able to handle grant/revoke access to any user-created key.
It only changes 1 key at a time to avoid mistakes. It reads it form a json generated split key file, then uses 'genSplitKey' which i modified to accept an argument 'key' in 'params' and makes the split with that key, if not 'key' 'param' is specified calling 'getSplitKey', a new key is generated.
$ bitgo help updatesplitkey
usage: bitgo updatesplitkey [-h] [-m M] [-n N] [-f FILE] [-k KEY]
Optional arguments:
-h, --help Show this help message and exit.
-m M new number of shares required to reconstruct a key
-n N new total number of shares per key
-f FILE, --file FILE the input file (JSON format)
-k KEY, --key KEY key index to update
And i added the command 'createtxfromjson' allows to create transacctions to multiple addresses using json notation.
This is the help options for this command:
$ bin/bitgo help createtxfromjson
usage: bitgo createtxfromjson [-h] [-j JSON] [-f FEE] [-c COMMENT] [-p PREFIX]
[-u]
Optional arguments:
-h, --help Show this help message and exit.
-j JSON, --json JSON json string {str addr: int value_in_satoshis, ...}
-f FEE, --fee FEE fee to pay for transaction
-c COMMENT, --comment COMMENT
optional private comment
-p PREFIX, --prefix PREFIX
output file prefix
-u, --unconfirmed allow spending unconfirmed external inputs